Skip to content

Add support for click handlers from selections #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 25, 2016
Merged

Add support for click handlers from selections #4

merged 2 commits into from
Feb 25, 2016

Conversation

etpinard
Copy link
Member

@etpinard etpinard commented Feb 5, 2016

This PR modifies:

  • the check is-scene-rotating check so that click events can propagate during selections.

@etpinard
modif scene is rotation definition:
6111ef7 
- determine that scene is rotating if both current
  and prev buttons are pressed
@etpinard
pass buttons to selection object
9b11fe9
@etpinard etpinard mentioned this pull request Feb 5, 2016
Merged
1 task
etpinard added a commit that referenced this pull request Feb 25, 2016
@etpinard
Merge pull request #4 from gl-vis/click-event
9392cb7 
Add support for click handlers from selections
@etpinard etpinard merged commit 9392cb7 into master Feb 25, 2016
@etpinard etpinard deleted the click-event branch February 25, 2016 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@etpinard