Update markers alignment #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etpinard
reviewed
Jun 12, 2017
There was a problem hiding this comment.
Thanks for the PR @dfcreative !
I suspect this needs dy/font-atlas-sdf@5a5a635 ?
| @@ -21,4 +21,4 @@ plot.draw() | |||
| ``` | |||
|
|
|||
| # License | |||
| (c) 2015 Mikola Lysenko. MIT License | |||
| (c) 2016 Dima Yv. MIT License | |||
scatter.js
Outdated
| @@ -7,7 +7,7 @@ var createBuffer = require('gl-buffer') | |||
| var pool = require('typedarray-pool') | |||
| var shaders = require('./lib/shaders') | |||
| var snapPoints = require('snap-points-2d') | |||
| var atlas = require('font-atlas-sdf') | |||
| var atlas = require('../font-atlas-sdf') | |||
|
Alright, here are the new baselines using this branch and https://github.com/plotly/plotly.js/compare/gl2d-scatter-sdf-marker-alignment |
|
Looking good. especially this one:
|
1 task
|
@dfcreative can you publish |
|
@etpinard done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aligns markers by optical center and makes their size more consistent, see optical-properties.
Probably needs merging to resolve plotly/plotly.js#1550