Set iframe background color on neovim's default_colors_set (#1637) #1638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue #1637 reports that resizing the underlying textarea of a Firenvim iframe can result in flashes of color. This can be particularly visible when using Firenvim with a dark colorscheme on Github in dark mode. The reason for these flashes of color is that when resizing, the iframe gets resized first and the Neovim canvas gets resized second, between these two moments, the iframe's background color can become visible if the CSS colorscheme of the iframe and of the website do not match. We fix this by ensuring that the iframe's background color is set to the background color of the Neovim colorscheme. This breaks the ability of the iframe to turn transparent when unfocused (the iframe gets dimmed instead), but given that multiple users complained about this feature, it may not be such a bad change. Closes #1637.
|
Hell yeah @glacambre. Background color's a great solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #1637 reports that resizing the underlying textarea of a Firenvim iframe can result in flashes of color. This can be particularly visible when using Firenvim with a dark colorscheme on Github in dark mode.
The reason for these flashes of color is that when resizing, the iframe gets resized first and the Neovim canvas gets resized second, between these two moments, the iframe's background color can become visible if the CSS colorscheme of the iframe and of the website do not match.
We fix this by ensuring that the iframe's background color is set to the background color of the Neovim colorscheme. This breaks the ability of the iframe to turn transparent when unfocused (the iframe gets dimmed instead), but given that multiple users complained about this feature, it may not be such a bad change.
Closes #1637.