Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NumPy 2 compatibility (+ drop 3.9 support) #163

Closed
ntessore opened this issue Jun 25, 2024 · 4 comments · Fixed by #391
Closed

NumPy 2 compatibility (+ drop 3.9 support) #163

ntessore opened this issue Jun 25, 2024 · 4 comments · Fixed by #391
Assignees
@paddyroddy
Labels
blocked The issue or pull request is blocked by something dependencies Pull requests that update a dependency file

Comments

@ntessore
Copy link
Collaborator

Ensure compatibility with the NumPy 2 release.
@ucapbba ucapbba self-assigned this Aug 27, 2024
@paddyroddy paddyroddy assigned paddyroddy and unassigned ucapbba Sep 10, 2024
This was referenced Sep 11, 2024
Closed
Closed
@paddyroddy
Copy link
Member

Going to start this with the help of https://docs.astral.sh/ruff/rules/#numpy-specific-rules-npy

@paddyroddy paddyroddy mentioned this issue Sep 12, 2024
Closed
@paddyroddy
Copy link
Member

Attempted in #207. I would say it is already compatible. However, at some point np.trapz will have to be replaced with np.trapezoid. If we do this now, then we are forced to drop 3.9 support (ref #198). For now, we are just dropping 3.8 support #326.

@paddyroddy
Copy link
Member

@paddyroddy paddyroddy mentioned this issue Oct 25, 2024
Closed
@paddyroddy paddyroddy changed the title NumPy 2 compatibility NumPy 2 compatibility (+ drop 3.9 support) Oct 25, 2024
@paddyroddy
Copy link
Member

Have updated the title to reflect the fact that we will need to drop 3.9 to support NumPy v2.1

@paddyroddy paddyroddy added the dependencies Pull requests that update a dependency file label Oct 25, 2024
@paddyroddy paddyroddy mentioned this issue Oct 30, 2024
Merged
@paddyroddy paddyroddy added the blocked The issue or pull request is blocked by something label Oct 30, 2024
@paddyroddy paddyroddy linked a pull request Oct 30, 2024 that will close this issue
gh-163: drop Python 3.9 & NumPy < 2.1.1 support #391
Merged
paddyroddy added a commit that referenced this issue Nov 18, 2024
@paddyroddy @pre-commit-ci
gh-163: drop Python 3.9 & NumPy < 2.1.1 support (#391)
d6c8cdb 
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paddyroddy paddyroddy

Labels
blocked The issue or pull request is blocked by something dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
3 participants
@ntessore @paddyroddy @ucapbba