Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-368: add type overloading for lensing.from_convergence #395

Merged
merged 173 commits into from
Nov 27, 2024

Conversation

paddyroddy
Copy link
Member

@paddyroddy paddyroddy commented Nov 1, 2024

Closes #386. Uses typing.overload to type all the possible outputs of the lensing.from_convergence function based on the values of the various boolean inputs.

Base automatically changed from paddy/issue-358 to main November 7, 2024 10:32
@paddyroddy paddyroddy changed the title gh-348: add overloading for functions with variable outputs gh-368: add overloading for functions with variable outputs Nov 15, 2024
@paddyroddy paddyroddy marked this pull request as ready for review November 15, 2024 16:34
Copy link
Member

@Saransh-cpp Saransh-cpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks good!

@paddyroddy paddyroddy changed the title gh-368: add overloading for functions with variable outputs gh-368: add type overloading for lensing.from_convergence Nov 15, 2024
@paddyroddy paddyroddy requested review from ntessore and removed request for ntessore November 21, 2024 11:44
@paddyroddy
Copy link
Member Author

Merging so it doesn't get stale

@paddyroddy paddyroddy merged commit f1e26d6 into main Nov 27, 2024
16 checks passed
@paddyroddy paddyroddy deleted the paddy/issue-386 branch November 27, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request infrastructure Project infrastructure: dev tools, packaging, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add overload typing to from_convergence
2 participants