Skip to content

gh-923: migrate from mypy to ty #926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
paddyroddy wants to merge 21 commits into
base: main
Choose a base branch
from
Draft

gh-923: migrate from mypy to ty #926

paddyroddy wants to merge 21 commits into from

Conversation

@paddyroddy
Copy link
Member

@paddyroddy paddyroddy commented Dec 19, 2025 •
edited
Loading

Description

This PR migrates from using mypy for type checking to ty. Currently awaiting the pre-commit

Closes: #923

Changelog entry

Changed: Swap out mypy to ty in the pre-commit hook

Checks

  • Is your code passing linting?
  • Is your code passing tests?
  • Have you added additional tests (if required)?
  • Have you modified/extended the documentation (if required)?
  • Have you added a one-liner changelog entry above (if required)?

@paddyroddy paddyroddy self-assigned this Dec 19, 2025
@paddyroddy paddyroddy added enhancement New feature or request infrastructure Project infrastructure: dev tools, packaging, etc. dependencies Pull requests that update a dependency file labels Dec 19, 2025
paddyroddy
paddyroddy commented Dec 22, 2025
View reviewed changes
.pre-commit-config.yaml
rev: v1.7.9
hooks:
- id: actionlint
- repo: https://github.com/pre-commit/mirrors-mypy
Copy link
Member Author

@paddyroddy paddyroddy Dec 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be replaced by the ty one when it exists

paddyroddy
paddyroddy commented Dec 22, 2025
View reviewed changes
pyproject.toml
Comment on lines +247 to +250
src.include = [
"glass",
"tests",
]
Copy link
Member Author

@paddyroddy paddyroddy Dec 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By default, examples would be included also

paddyroddy
paddyroddy commented Dec 22, 2025
View reviewed changes
pyproject.toml
Comment on lines +246 to +249
overrides."tool.ty".first = [
"rules",
"src",
]
Copy link
Member Author

@paddyroddy paddyroddy Dec 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confused why this is needed pappasam/toml-sort#94

@paddyroddy paddyroddy marked this pull request as ready for review December 22, 2025 10:04
@paddyroddy paddyroddy added the blocked The issue or pull request is blocked by something label Dec 22, 2025
@paddyroddy paddyroddy marked this pull request as draft January 7, 2026 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@connoraird connoraird Awaiting requested review from connoraird

At least 1 approving review is required to merge this pull request.

Assignees

@paddyroddy paddyroddy

Labels

blocked The issue or pull request is blocked by something dependencies Pull requests that update a dependency file enhancement New feature or request infrastructure Project infrastructure: dev tools, packaging, etc.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Use ty for type checking support

2 participants

@paddyroddy