Fix to retry with given delay time, not with random time and to raise TimeoutException #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… TimeoutException
stanevicius1
approved these changes
Feb 13, 2020
|
any chance this pr getting merged anytime soon? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned like #13,
Have modified to retry with the fixed delay time, not with random time between 0 ~ 200ms to avoid unluckily situation which could fail to acquire lock in zero seconds. And also modified to raise RedLockError when retry times has elapsed than TTL while retrying to acquire lock. In fact, not sure what the right way is, 'cause I'm newbie to here.