Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trigger syntax error when encountering array unpacking with reference #461

Merged
merged 1 commit into from
Jan 3, 2020
Merged

Trigger syntax error when encountering array unpacking with reference #461

merged 1 commit into from
Jan 3, 2020

Conversation

loilo
Copy link
Contributor

@loilo loilo commented Jan 3, 2020

Currently, this is allowed by the parser:

[...&$arr]

However, this is incorrect and should trigger a syntax error (RFC, example).

@loilo loilo mentioned this pull request Jan 3, 2020
Merged
@coveralls
Copy link

Coverage Status

Coverage increased (+0.002%) to 96.145% when pulling 463a0cc on loilo:fix-unpacking-with-reference into 407e4d4 on glayzzle:master.

alexander-akait
alexander-akait approved these changes Jan 3, 2020
View reviewed changes
Copy link
Collaborator

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job

/cc @ichiriac

ichiriac
ichiriac approved these changes Jan 3, 2020
View reviewed changes
Copy link
Member

@ichiriac ichiriac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great 👍

@ichiriac ichiriac merged commit 06d8bdc into glayzzle:master Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexander-akait alexander-akait alexander-akait approved these changes

@ichiriac ichiriac ichiriac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@loilo @coveralls @ichiriac @alexander-akait