2278 path dependencies module resolution bug #2334
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
marked this pull request as ready for review
ghost
marked this pull request as draft
ghost
marked this pull request as ready for review
lpil
reviewed
Sep 18, 2023
compiler-cli/src/dependencies.rs
Outdated
| }; | ||
| } | ||
| Ok(dependencies) | ||
| } |
There was a problem hiding this comment.
I think this will fail for nested path deps, as the path will be relative to the dep and not the root of the project.
compiler-cli/src/dependencies.rs
Outdated
| @@ -500,9 +500,11 @@ fn get_manifest<Telem: Telemetry>( | |||
|
|
|||
| let manifest = read_manifest_from_disc(paths)?; | |||
|
|
|||
| let dependencies = get_all_dependencies(config)?; | |||
There was a problem hiding this comment.
This detection is being done at the very edge of the system, when the CLI starts. It works for the CLI build tool as it always starts from scratch, but the problem will still exist for the language server which is a long-running process. We'll need to determine an approach that works in that case also.
ghost
marked this pull request as draft
ghost
closed this
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2278
When building a project, we must check that a manifest file already exists. If the manifest exists, then we must check that it is up to date. It is at this stage that the issue occurs. When verifying the manifest, we currently only check for changes in the root config file. This does not account for changes in the config files of local packages that occur after the root manifest is generated. To resolve this, I've added a check for changes in local package config files.