suggest unlocking locked pkgs that cause dep resolution failures #3970
+232
−35
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3622
Changes:
Error::dependency_resolution_failed
to detect dependency resolution failures due to locked packages in two waysResolutionError::NoSolution
. These are errors where a locked package version is incompatible with a new package added viagleam add
or via a manualgleam.toml
update andgleam deps download
AND the locked package is not constrained inmanifest.toml
. More manual testing is needed for the larger cli interactions.resolution_locked_version_doesnt_satisfy_requirements_indirect
tests this case.locked
map is not in the range specified inrequirements
.resolution_locked_version_doesnt_satisfy_requirements
tests this case.DependencyResolutionFailedWithLocked
to allow pattern matching later to start the CLI action (waiting for user to [y/n] the suggestion)Questions for reviewers:
Ty