Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

floating point values outside Erlang's floating point range should cause error #4118

Merged
merged 2 commits into from
Jan 9, 2025
Merged

floating point values outside Erlang's floating point range should cause error #4118

merged 2 commits into from
Jan 9, 2025

Conversation

massivefermion
Copy link
Contributor

closes #4116

lpil
lpil reviewed Dec 30, 2024
View reviewed changes
Copy link
Member

@lpil lpil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! Thank you. I've left some small notes inline

CHANGELOG.md Outdated Show resolved Hide resolved
compiler-core/src/type_/error.rs

/// When targeting Erlang, adds an error if the given Float value is outside the range
/// -1.7976931348623157e308 to 1.7976931348623157e308 which is the allowed range for
/// Erlang's floating point numbers
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we link to there these numbers were taken from in the Erlang docs please 🙏

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually can't find them anywhere in the Erlang docs. I got them from here.

compiler-core/src/type_/tests/errors.rs Show resolved Hide resolved
lpil
lpil reviewed Jan 6, 2025
View reviewed changes
Copy link
Member

@lpil lpil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you rebase on main please? The changelog has a conflict 🙏

lpil
lpil approved these changes Jan 9, 2025
View reviewed changes
Copy link
Member

@lpil lpil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!

@lpil lpil merged commit c9ca4b7 into gleam-lang:main Jan 9, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpil lpil lpil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Illegal float literals crash when targeting Erlang
2 participants
@massivefermion @lpil