Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Change the semantics of bitwise operations to be fully platform-dependent #802

Closed
wants to merge 1 commit into from
Closed

Proposal: Change the semantics of bitwise operations to be fully platform-dependent #802

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 6 additions & 11 deletions src/gleam_stdlib.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -763,33 +763,28 @@ export function byte_size(string) {
return new TextEncoder().encode(string).length;
}

// In Javascript bitwise operations convert numbers to a sequence of 32 bits
// while Erlang uses arbitrary precision.
// To get around this problem and get consistent results use BigInt and then
// downcast the value back to a Number value.

export function bitwise_and(x, y) {
return Number(BigInt(x) & BigInt(y));
return x & y;
}

export function bitwise_not(x) {
return Number(~BigInt(x));
return ~x;
}

export function bitwise_or(x, y) {
return Number(BigInt(x) | BigInt(y));
return x | y;
}

export function bitwise_exclusive_or(x, y) {
return Number(BigInt(x) ^ BigInt(y));
return x ^ y;
}

export function bitwise_shift_left(x, y) {
return Number(BigInt(x) << BigInt(y));
return x << y;
}

export function bitwise_shift_right(x, y) {
return Number(BigInt(x) >> BigInt(y));
return x >> y;
}

export function inspect(v) {
Expand Down
Loading