Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove-unused not working, composed task does #108

Closed
allaire opened this issue Nov 11, 2014 · 7 comments
Closed

remove-unused not working, composed task does #108

allaire opened this issue Nov 11, 2014 · 7 comments

Comments

@allaire
Copy link

allaire commented Nov 11, 2014

Hi,

remove unused is not working in my case, but i18n-tasks unused -fyaml | i18n-tasks data-remove does.

My case is quite special, in my i18n-tasks config I have config/locales/**/*.yml for both read and write. What's special is that I have a directory under locales/ that is called _sources/. This folder contains duplicate data for the fr language (we're using crowdin.net and it's a neat trick that I found).

remove unused delete every keys/strings I have in _sources/, where the other composed task option works correctly and remove duplication like i18n-tasks unused shows.

Any ideas?

Thanks!

@glebm
Copy link
Owner

glebm commented Nov 12, 2014

As I understand, you do not want i18n-tasks to interact with the keys under _sources?
Could you please post the output of all the commands you use here? A test case would be even better.

Could be related to #104

@allaire
Copy link
Author

allaire commented Nov 12, 2014

I do want to interact with the keys under _sources. But for some reason, all my keys get deleted, even if they are nested under fr: at the root of the yaml

@glebm
Copy link
Owner

glebm commented Nov 12, 2014

Could you post a simple test case? Or reproduce the structure and put it on Github?

@allaire
Copy link
Author

allaire commented Nov 12, 2014

@glebm Here's a quick gist with screenshots: https://gist.github.com/allaire/9439fd2bd0919b944faa

@allaire
Copy link
Author

allaire commented Nov 20, 2014

Is this enough?

@glebm
Copy link
Owner

glebm commented Nov 21, 2014

Can you add a failing test case please? 🙇

@glebm glebm added the bug label Nov 21, 2014
glebm added a commit that referenced this issue Aug 2, 2015
Fixes. #162
Additionally, fixes the `data-remove` task. #140
Possibly fixes. #108
@glebm glebm added this to the v0.8.6 milestone Aug 2, 2015
@glebm
Copy link
Owner

glebm commented Aug 2, 2015

This might be fixed in v0.8.6, please give it a try.

@glebm glebm closed this as completed Aug 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants