-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doesn't work with locale as directory #176
Comments
Ah, I just found it's because I was missing router: pattern_router Maybe this should be better documented? |
Hi, I've added a note about that and the alternative option to the Readme. Looks good? |
Yes it's better but, the following is unexpected:
does The problem I had is that |
I missed the part in your original post that said:
There is a bug in the conservative router here, where it does locale replacement for the matched path. The way it does it is brittle, but it can be easily modified to match |
This is super brittle and needs to be improved eventually. Refs #176
I've attempted to fix this above. Does the master branch work for you? |
@glebm thanks for working on this, I've been having the same problem. Would it be possible for you to release a beta version of the gem to rubygems.org so I can test to see if this fixes it? |
I'm in a rush at work, so I won't be able to test this before the end of the week... but it looks good. |
@connorshea You can test with: gem 'i18n-tasks', git: 'https://github.com/glebm/i18n-tasks' |
* upstream/master: (70 commits) Readme: bump version Bump to 0.9.2 Fix ActiveSupport >= 4.0, < 4.2 compat Added note to README to stop anyone else wasting an hour of their time. Replace multiple instances of %{locale} in path Match %{locale}/ for path locale replacement Readme: a note on the routers glebm#176 Bump to 0.9.1 I18n::Tasks.add_scanner, I18n::Tasks.add_commands Trivial refactoring in used_keys.rb Revert "ActiveSupport < 4 compat" Fix bin/18n-tasks tests on travis Only match I18n or nil receivers in PatternScanner Add required_ruby_version to gemspec Bump to 0.9.0 Remove WIP temple scanner classes AST Scanner: fix magic comment location reporting Use AST::Sexp helpers instead of AST::Node.new travis: Test on Ruby 2.2.3 (was 2.2.2) Depend on ast 2.1.0+. ...
Hello,
The following structure doesn't seem to work (my
en
locale gets overwritten with thefr
one):Maybe related to #14
This happens when I do
i18n-tasks add-missing
The text was updated successfully, but these errors were encountered: