Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color metadata & single-channel use case #170

Closed
sbesson opened this issue Oct 31, 2022 · 0 comments · Fixed by #171
Closed

Color metadata & single-channel use case #170

sbesson opened this issue Oct 31, 2022 · 0 comments · Fixed by #171

Comments

@sbesson
Copy link
Member

sbesson commented Oct 31, 2022

#160 introduced the population of the omero metadata specification by this conversion tool.

The new logic populates the mininum/maximum values per channel but also stores some channel metadata like the color. The relevant portion of the code is largely inherited from omero-blitz ChannelProcessor to try to set a meaningful value based on various metadata fields and invoked in

Color color = Colors.getColor(omexml, seriesIndex, c);

While testing different conversion workflows, I noticed one particular deviation in the case of single-channel image. This can be tested by

% bioformats2raw test.fake test.zarr
% grep color test.zarr/0/.zattrs 
      "color" : "FF0000",

In the case of single-channel data, the OMERO importer calls a separate setSingleChannel method which sets the color to grey instead.

https://github.com/ome/omero-blitz/blob/5d27e4771af5c4c457464090edb5b450d1c11e1d/src/main/java/ome/formats/model/ChannelProcessor.java#L106-L119

Should bioformats2raw be updated to adopt the same behavior?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant