Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GPL license metadata to published POM #227

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

sbesson
Copy link
Member

@sbesson sbesson commented Nov 28, 2023

Following a discussion yesterday with @DavidStirling and @melissalinkert about generating a public report of the NGFF dependencies and their licenses, this should add the licensing metadata to the POM for this component and simplify the downstream aggregation and reporting.

This can be tested by running ./gradlew publishToMavenLocal. Without this PR, the POM file stored under ~/.m2/repository should have no license markup. With this PR included, it should include a single license referencing the GNU GPL v2 as per the top-level license of the repository

Copy link
Member

@melissalinkert melissalinkert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this PR, the generated POM includes:

<licenses>
    <license>
      <name>GNU General Public License version 2</name>
      <url>http://www.gnu.org/licenses/gpl-2.0.txt</url>
    </license>
  </licenses>

which was not present without this PR.

@melissalinkert melissalinkert merged commit 3d9187c into glencoesoftware:master Nov 28, 2023
4 checks passed
@sbesson sbesson deleted the pom_license branch November 28, 2023 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants