Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix progress and help options #234

Merged

Conversation

melissalinkert
Copy link
Member

As discussed earlier today with @sbesson and @chris-allan.

With this change, commands similar to:

$ bioformats2raw --help
$ bioformats2raw -p --foo test.fake test.zarr
$ bioformats2raw -p --help

should print a usage message and exit.

I don't know why the help flag was set for -p/--progress-bars, maybe @joshmoore remembers from the initial implementation in #83?

raw2ometiff will need a similar update once we're happy with the state of this PR.

This should fix unexpected behavior when "-p" is used with other (potentially invalid) options.
@joshmoore
Copy link
Contributor

Uff. My guess is that it was a copy-n-paste error.

Copy link
Member

@chris-allan chris-allan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Progress option interactions now work as I would expect. Can we use the standard options for --help?

@melissalinkert
Copy link
Member Author

Can we use the standard options for --help?

Main reason I didn't do that here was that we already define -h as the short option for setting the tile height.

@chris-allan chris-allan merged commit 7ddc0ee into glencoesoftware:master Jan 18, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants