Log an error instead of throwing an exception if the microservice check fails #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ck fails This prevents a dialog that indicates login failed (it didn't) and allows limited functionality for image types that don't require the microservice.
|
This resolves the issue - login is successful despite microservice being unavailable (which is logged).
Fluorescence data is appropriately blocked from import. RGB data import and viewing works as expected. Noting as well that the QuPath extension manager does not work with our current releases because a .jar with a particular naming convention (I think, see URL in screenshot below) is expected:
Our latest release artifact is here for comparison: https://github.com/glencoesoftware/qupath-extension-omero-web/releases/download/v0.4.1-gs/qupath-extension-omero-gs.zip |
erindiel
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents a dialog that indicates login failed (it didn't) and allows limited functionality for image types that don't require the microservice.