Fix RGB ZCT coordinate calculation #112
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported by @sbesson, a simple conversion with the
--rgb
flag logs numerousIllegalArgumentException
s indicating that the ZCT coordinates could not be calculated.Without this PR, the build passes, indicating that the unit tests that use the
--rgb
test also pass. However, examining the test output inbuild/reports/tests/test/classes/
will show similarIllegalArgumentException
s in theStandard error
section of the test report. The ZCT coordinate calculation is only requested in https://github.com/glencoesoftware/raw2ometiff/blob/master/src/main/java/com/glencoesoftware/pyramid/PyramidFromDirectoryWriter.java#L1537, to get the correct plane index for progress notifications. This happens after the tile has already been written; effectively, it is just the progress notification that is failing. This explains why the test does not fail; the actual conversion does in fact succeed and the output file is valid and readable.With this PR, the
IllegalArgumentException
s should no longer appear in the test report or conversion output. The actual output OME-TIFF with and without this PR should be unchanged.