Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a testcase for local reporter path #66

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

just-boris
Copy link
Contributor

@just-boris just-boris commented Aug 23, 2019

Full reproducible example for #65

(Fixes #65)

@just-boris
Copy link
Contributor Author

UPD: the commit bc31ced also contains the fix

Copy link
Owner

@glenjamin glenjamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix makes sense.

Could you leave the mocha-multi.js file where it was, and add the dummy reporter to the verify script at the bottom too?

@just-boris
Copy link
Contributor Author

This won’t work unfortunately. If mocha-multi.js stays at the top level it will not reproduce the issue. The CWD and the location of mocha-multi.js file will match and require('./fixtures/dummy-reporter.js') will be working without the fix.

So the point of the change is to split the location of the file and working directory

@glenjamin
Copy link
Owner

Aha, I see! That wasn’t obvious to me but it does make sense now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support relative path as a reporter name
2 participants