Add regex to catch errors without file/line information #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We discovered that in some instances, Typescript will return an error that isn't associated with a specific file, line, or col.
For example:
error TS2688: Cannot find type definition file for 'ember__test-helpers'.
In these cases, typescript-xunit-xml was returning a result which looked identical to a passing
tsc
compile (0 errors), and our builds were passing when they shouldn't.At least for our use case, it would be really helpful to report out those errors as well. Is that something the broader community might want? Here's one proposal to fix that, which introduces a separate regex to catch the errors.