_Underscored files are being compiled in v5 rc1 #50
Comments
|
Sorry I'm not able to replicate this. The setting to exclude partial files is hardcoded into the program, so how this is happening is completely baffling me. Edit: what happens in the sample project (Test.zip). I saved both Here's rc1.1 (which I will release as rc2 - if all is well - after some doc changes) And here's the sample package I was testing with To install rc1.1:
Can you follow the below steps and comment the info for me:
|
|
@glenn2223 I'll try this tomorrow when I have a longer moment for this. What I did observe with rc1 is the following, maybe that helps already: In fact I have the following file structure: All files are being imported in the When I save the style.scss file, only the |
Thanks, and there's no rush. I just appreciate the time you're taking to help out.
I'll expand my test and see if I can replicate
v5 has had a massive overhaul. Part of that was a transition from the |
|
@glenn2223 I'd love to replicate the THANKS (and a huge one) for taking the time to really improve this plugin - I can already tell it's so much faster (and possibly not only because of the removal of Live Server dependency), and seeing how involved you are with it is really inspiring! Really getting the gist of re-structuring a whole plugin, and let's hope we can tackle this one 😊! |
Thank you, that means a lot 😁
You should be able to just drag it into "Extensions" tab and it will overwrite the currently installed version and ask you to reload |
|
@glenn2223 Phew, I hope I got it right with the output logging. I did in fact save the style.scss (only the style compiles), and afterwards saved one of the partial files. Again, the same result - _print and _variables are being compiled if I save one of the partials (saved the _basics.scss in this case, _print and _variables being compiled). Here is the log, I hope a direct copy is good for you? |
|
@glenn2223 Just again, the compilation error result from auto-compiling the partial files, the style.scss compiles just fine. |
|
Thank you for the information (exactly what I needed) I've found the problem and fixed it, will release rc4 soon. So, this part here: Should have just read Turns out that I wasn't checking files aren't partials when I was searching for all SASS files. Hence the below happened later on in the process Sorry, when I tested I was only saving the main file and not the partial so I completely skipped over this 🤦♂️ Will close on rc4 release |
Merged
|
@glenn2223 Wow, you got that one sorted quickly. Very much appreciated. Have some nice holidays! |
Yeah, as soon as I saw those lines I knew where I'd gone wrong
Thank you. You too |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Up until version 4, SCSS files starting with an underscore hadn't been compiled by themselves. v5 rc1 now compiles the corresponding files (in my case
.min.cssand.css) for the partial ones when I save one of them.Project structure (example)
_basics.scssstyle.scss(importing the _basics.scss in the beginning:@import 'basics';)Previous behaviour
Saving
_basics.scssonly triggers a save ofstyle.scssand a compilation of the CSS files for it if it is open (if I am not mistaken), no_basics.cssor_basics.min.cssare created.Current behaviour
Saving
_basics.scsstriggers a compilation of CSS Files for it, e.g._basics.cssor_basics.min.css, and triggers errors because the single imported files with underscores only work in tandem with each other when imported into the styles.scss.Edit: This is the file structure:
These are my settings:
The text was updated successfully, but these errors were encountered: