Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Rewrite in TypeScript, use bun as runtime #20

Merged
merged 1 commit into from
Feb 1, 2024
Merged

Refactor: Rewrite in TypeScript, use bun as runtime #20

merged 1 commit into from
Feb 1, 2024

Conversation

glensc
Copy link
Owner

@glensc glensc commented Jan 25, 2024

Why?

The original version was written in 2002:

At that time, it was better alternative than shell scripting and awk, and there weren't really other options out there.

Currently this has become a problem. The app does not work properly in docker container:

The ecosystem is also unknown to me, and the syntax and language glitches are already getting forgotten.

This is also barrier for contributions, for unknown language and difficult to test people don't submit contributions.

Also sending emails from local linux box has become an issue in 2024, you need to set up MARC, DKIM, and SPF? etc for emails not to end up in Spam. So instead of that, use some provider like sendgird of gmail smtp.

tasks

Bun facts

Bun shortcomings

Mail sending

Sendgrid:

Gmail:

Create App password:

DOM parsing

@glensc glensc marked this pull request as ready for review February 1, 2024 21:28
@glensc
Copy link
Owner Author

glensc commented Feb 1, 2024

Extracted things logically (as possible) and leaving just main.ts change here. Further changes will be done in normal flow.

@glensc glensc merged commit 41b4e8d into main Feb 1, 2024
@glensc glensc deleted the bun branch February 1, 2024 21:29
@glensc glensc mentioned this pull request Feb 2, 2024
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant