Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding missing export of new Golang option #2450

Conversation

SirAlvarex
Copy link
Contributor

Followup to #2449

Apologies, I was concentrating on adding the functionality to the library I needed, I didn't check how the flag was exported. Unintended screw up due to my over-reliance on the live reload functionality.

@dvdsgl
Copy link
Member

dvdsgl commented Dec 1, 2023

Build failed

@SirAlvarex
Copy link
Contributor Author

@dvdsgl

I ran the test in a Codespace and was able to get a success. I don't seem to have the ability to trigger a rebuild of the PR without submitting a new commit. Is there another way to get just this test retriggered?

@SirAlvarex ➜ /workspaces/quicktype (SirAlvarex/golang-omit-empty-update-second-reference) $ QUICKTEST=true FIXTURE=json-ts-csharp npm test

> quicktype@23.0.0 test
> script/test

* Running a subset of fixtures: json-ts-csharp
* Running 38 tests between 1 fixtures
* Setting up json-ts-csharp fixture
* Forking 2 workers 👷🏽 👷🏽
* Running a subset of fixtures: json-ts-csharp
* Running a subset of fixtures: json-ts-csharp
* [38/38] json-ts-csharp() test/runs/json-ts-csharp-21a33c/us-senators.json: 10252 ms
* [37/38] json-ts-csharp() test/runs/json-ts-csharp-d0454c/us-avg-temperatures.json: 10208 ms
* [35/38] json-ts-csharp() test/runs/json-ts-csharp-aa3ac4/simple-object.json: 6345 ms
* [36/38] json-ts-csharp() test/runs/json-ts-csharp-d431a6/spotify-album.json: 6969 ms
* [32/38] json-ts-csharp() test/runs/json-ts-csharp-a6263e/null-safe.json: 6890 ms
* [34/38] json-ts-csharp() test/runs/json-ts-csharp-d1ca62/reddit.json: 7502 ms
* [29/38] json-ts-csharp() test/runs/json-ts-csharp-fc838d/getting-started.json: 5651 ms
* [31/38] json-ts-csharp() test/runs/json-ts-csharp-e2e02c/kitchen-sink.json: 5994 ms
* [28/38] json-ts-csharp() test/runs/json-ts-csharp-cd121a/bitcoin-block.json: 5183 ms
* [27/38] json-ts-csharp() test/runs/json-ts-csharp-5438b1/url.json: 5347 ms
* [26/38] json-ts-csharp() test/runs/json-ts-csharp-38f64e/unions.json: 5166 ms
* [25/38] json-ts-csharp() test/runs/json-ts-csharp-0c4968/union-constructor-clash.json: 5602 ms
* [24/38] json-ts-csharp() test/runs/json-ts-csharp-edfcd0/simple-identifiers.json: 5022 ms
* [23/38] json-ts-csharp() test/runs/json-ts-csharp-67c4b7/recursive.json: 5469 ms
* [21/38] json-ts-csharp() test/runs/json-ts-csharp-e660fa/number-map.json: 5172 ms
* [20/38] json-ts-csharp() test/runs/json-ts-csharp-0448bc/nst-test-suite.json: 5711 ms
* [17/38] json-ts-csharp() test/runs/json-ts-csharp-a3e068/name-style.json: 4893 ms
* [16/38] json-ts-csharp() test/runs/json-ts-csharp-755841/list.json: 5232 ms
* [14/38] json-ts-csharp() test/runs/json-ts-csharp-f74392/identifiers.json: 5788 ms
* [15/38] json-ts-csharp() test/runs/json-ts-csharp-01125c/keywords.json: 8376 ms
* [12/38] json-ts-csharp() test/runs/json-ts-csharp-7fe90d/direct-recursive.json: 5346 ms
* [11/38] json-ts-csharp() test/runs/json-ts-csharp-4bf15a/combined-enum.json: 5539 ms
* [9/38] json-ts-csharp() test/runs/json-ts-csharp-55789c/combinations3.json: 7525 ms
* [10/38] json-ts-csharp() test/runs/json-ts-csharp-4ebcc9/combinations4.json: 8187 ms
* [7/38] json-ts-csharp() test/runs/json-ts-csharp-b577f0/combinations1.json: 6789 ms
* [8/38] json-ts-csharp() test/runs/json-ts-csharp-922fe0/combinations2.json: 8312 ms
* [6/38] json-ts-csharp() test/runs/json-ts-csharp-384135/coin-pairs.json: 5371 ms
* [3/38] json-ts-csharp() test/runs/json-ts-csharp-cb3a1d/bug790.json: 5685 ms
* [2/38] json-ts-csharp() test/runs/json-ts-csharp-561248/bug427.json: 6624 ms
* [1/38] json-ts-csharp() test/runs/json-ts-csharp-01111c/blns-object.json: 6340 ms

@dvdsgl dvdsgl enabled auto-merge (squash) February 14, 2024 13:10
@dvdsgl dvdsgl merged commit cb0adcd into glideapps:master Feb 14, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants