Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Revert import order to fix imported class being not yet defined" #2600

Merged
merged 1 commit into from
May 18, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions packages/quicktype-core/src/TypeUtils.ts
Original file line number Diff line number Diff line change
@@ -1,13 +1,14 @@
import { EqualityMap, iterableFirst, setFilter, setSortBy, setUnion } from "collection-utils";

// eslint-disable-next-line import/no-cycle
import { type StringTypes, stringTypesTypeAttributeKind } from "./attributes/StringTypes";
import {
type CombinationKind,
type TypeAttributes,
combineTypeAttributes,
emptyTypeAttributes
} from "./attributes/TypeAttributes";
import { assert, assertNever, defined, panic } from "./support/Support";
// eslint-disable-next-line import/no-cycle
import {
ArrayType,
type ClassProperty,
Expand All @@ -21,9 +22,6 @@ import {
UnionType,
isPrimitiveStringTypeKind
} from "./Type";
// String types should be imported last to avoid circular dependency issues.
// eslint-disable-next-line import/order
import { type StringTypes, stringTypesTypeAttributeKind } from "./attributes/StringTypes";

export function assertIsObject(t: Type): ObjectType {
if (t instanceof ObjectType) {
Expand Down
Loading