Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix argmuent parsing for gwms-factory upgrade #323

Merged
merged 1 commit into from
Jul 28, 2023
Merged

Fix argmuent parsing for gwms-factory upgrade #323

merged 1 commit into from
Jul 28, 2023

Conversation

BrunoCoimbra
Copy link
Contributor

This PR removes a redundant if statement that contained a bash syntax error. The extra statement prevented commands such as gwms-factory upgrade -force_delete from working as expected, making it impossible to remove entries from Factories.

From shellcheck:

Arrays don't work as operands in [ ]. Use a loop (or concatenate with * instead of @).

@mambelli mambelli merged commit d236694 into glideinWMS:master Jul 28, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mambelli mambelli mambelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BrunoCoimbra @mambelli