Added support for structured logs #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
namrathaurs
requested changes
Aug 14, 2023
|
Minor changes suggested. Note: The failing pylint build check was discussed as a known problem, but based on Marco's understanding, this is expected to be resolved once the changes get merged with the main branch. |
mambelli
force-pushed
the
anita-structLogChanges_v2
branch
from
5d9f3e5
to
2c965a9
Compare
mambelli
force-pushed
the
anita-structLogChanges_v2
branch
from
2c965a9
to
6c09ae2
Compare
namrathaurs
requested changes
Aug 23, 2023
mambelli
force-pushed
the
anita-structLogChanges_v2
branch
4 times, most recently
from
3fc6667
to
ccb8b50
Compare
mambelli
force-pushed
the
anita-structLogChanges_v2
branch
3 times, most recently
from
503084a
to
11019dd
Compare
…ct fields/keys and improved log initialization and consolidated handler's setup Using booleans True/False instead of 1/0 in rollover control in logSupport Reverted manual_glidein_submit.py to use std Python logging (it is and standalone script not using the framework log files) Fixed type of log-rotation specifications (maxDays, minDays and maxMBytes) that can be float Fixed minDays that previously was ignored Added documentation and adapted unit tests Added unit test for logging level Consolidated also is_true() to lib/util.py Cleaned up some docstrings and comments
mambelli
force-pushed
the
anita-structLogChanges_v2
branch
from
11019dd
to
fcdec12
Compare
|
Locally is completing successfully all unit tests. Before the time rotation was timing out. The culprit was the |
namrathaurs
approved these changes
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added changes to support structured logs:
logSupportStructured logs are disabled by default to ease the transition. They can be enabled by adding
structured="True"to the configuration of the logs (process_logsections in the Factory and Frontend configurations)Added also some general improvements: cleanup of comments and docstrings, consolidation of
util.is_true(), and fixed a couple of small bugs.The first commits are by @MissAnita2
This PR replaces PR #327 because GitHub got confused from the rebase eliminating the HTML files changes.
And that PR replaced Anita's PR #325 because I reverted once the automatic unrelated changes to all HTML files and was unable to force-update when they were re-applied
Suggestions from @namrathaurs review of PR #327 have been applied