Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor GlideinWMS Credentials #363

Open
wants to merge 4 commits into
base: branch_v3_11
Choose a base branch
from
Open

Refactor GlideinWMS Credentials #363

wants to merge 4 commits into from

Conversation

BrunoCoimbra
Copy link
Contributor

This PR implements major refactoring to the GlideinWMS credentials.
The current version features:

  • A new Credentials class
  • Multi-type auth_method
  • Security parameters

@mambelli mambelli added the rel:3.11.0 Release label for v3.11.0 label Dec 19, 2023
@BrunoCoimbra BrunoCoimbra force-pushed the credentials-refactor branch 3 times, most recently from 3f9ea25 to 443e1a9 Compare December 20, 2023 21:57
@BrunoCoimbra BrunoCoimbra force-pushed the credentials-refactor branch 3 times, most recently from 3110284 to eab7a04 Compare January 12, 2024 16:15
@namrathaurs namrathaurs added this to the 3.11.0 milestone Feb 7, 2024
@BrunoCoimbra BrunoCoimbra changed the title Add credentials class auth_method list and params Refactor GlideinWMS Credentials Mar 6, 2024
@BrunoCoimbra BrunoCoimbra force-pushed the credentials-refactor branch 2 times, most recently from f0747fd to b580f84 Compare March 7, 2024 00:01
mambelli
mambelli requested changes Mar 7, 2024
View reviewed changes
Copy link
Contributor

@mambelli mambelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

part 1

build/packaging/rpm/glideinwms.spec Outdated Show resolved Hide resolved
creation/lib/cgWCreate.py Show resolved Hide resolved
creation/lib/cvWParams.py Outdated Show resolved Hide resolved
creation/web_base/setup_x509.sh Outdated Show resolved Hide resolved
creation/web_base/setup_x509.sh Show resolved Hide resolved
factory/glideFactoryEntry.py Outdated Show resolved Hide resolved
factory/glideFactoryEntry.py Outdated Show resolved Hide resolved
factory/glideFactoryEntry.py Outdated Show resolved Hide resolved
factory/glideFactoryEntry.py Outdated Show resolved Hide resolved
factory/glideFactoryEntry.py Outdated Show resolved Hide resolved
mambelli
mambelli requested changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@mambelli mambelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

part 2 (3 will come soon)

factory/glideFactoryLib.py Outdated Show resolved Hide resolved
factory/glideFactoryLib.py Show resolved Hide resolved
factory/glideFactoryLib.py Show resolved Hide resolved
frontend/glideinFrontendConfig.py Show resolved Hide resolved
frontend/glideinFrontendElement.py Show resolved Hide resolved
lib/credentials.py Show resolved Hide resolved
lib/credentials.py Outdated Show resolved Hide resolved
lib/credentials.py Outdated Show resolved Hide resolved
lib/credentials.py Outdated Show resolved Hide resolved
lib/credentials.py Show resolved Hide resolved
mambelli
mambelli requested changes Mar 20, 2024
View reviewed changes
Copy link
Contributor

@mambelli mambelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

part 3

frontend/glideinFrontendElement.py Outdated Show resolved Hide resolved
frontend/glideinFrontendElement.py Outdated Show resolved Hide resolved
frontend/glideinFrontendElement.py Show resolved Hide resolved
frontend/glideinFrontendElement.py Show resolved Hide resolved
frontend/glideinFrontendInterface.py Outdated Show resolved Hide resolved
frontend/glideinFrontendInterface.py Outdated Show resolved Hide resolved
frontend/glideinFrontendInterface.py Show resolved Hide resolved
frontend/glideinFrontendInterface.py Show resolved Hide resolved
frontend/glideinFrontendInterface.py Show resolved Hide resolved
@BrunoCoimbra BrunoCoimbra force-pushed the credentials-refactor branch 7 times, most recently from 7b51b1d to 4d6021c Compare July 9, 2024 18:55
@BrunoCoimbra BrunoCoimbra force-pushed the credentials-refactor branch 4 times, most recently from bd9d8ff to 856caaf Compare July 11, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mambelli mambelli mambelli requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
rel:3.11.0 Release label for v3.11.0
Projects
None yet
Milestone
3.11.0
Development

Successfully merging this pull request may close these issues.
3 participants
@BrunoCoimbra @mambelli @namrathaurs