Only copy from app import path to app path when building #467
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #402 (slug generate gzips from /tmp/app, when it should gzip from /app) and #321 (Cannot execute any Procfile commands) and fixed the issue mentioned in the blog post "Running Herokuish apps in Docker".
Currently every time herokuish is run the app import path (e.g. /tmp/app) is copied over to the app path (e.g. /app) if the import path exists and has files in it.
This PR changes this so that the copy from the import path to the app path is only done on running
herokuish buildpack build
orherokuish buildpack test
as suggested by @matthewmueller in #402.This means that you can now run
buildpack build
immediately followed byprocfile start
within the same container and things will work.I can see at least two different ways that people were working around this issue before:
buildpack build
and then running a container from that image which doesn't have a volume mounted at /tmp/app and so the contents of /app is not overwritten.This PR should not break those workarounds.