added Consul TCP Health Check #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this a duplicate of #307? |
|
Yes, it is an identical fix.... On Mon, Feb 29, 2016 at 5:09 PM, Dave Henderson notifications@github.com
ing.Mark van Holsteijn |
| ``` | ||
|
|
||
| It works for services on any port, not just 80. If its the only service, | ||
| you can also use `SERVICE_CHECK_HTTP`. |
There was a problem hiding this comment.
I think you mean SERVICE_CHECK_TCP here
|
@mvanholsteijn - ok, I like yours better because it has docs 😁 |
|
/cc @josegonzalez @MattAitchison @michaelshobbs - any chance of getting this (or #307) merged soon? |
|
@hairyhenderson I removed the superflously copied line from HTTP health check. |
|
Thank you, I needed this. |
mattatcha
added a commit
that referenced
this pull request
Mar 5, 2016
added Consul TCP Health Check
|
Thank you @MattAitchison! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a Consul TCP health check by specifying ..._CHECK_TCP=true
issue #225