Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix service ip and port in consul interpolateService #453

Merged
merged 1 commit into from
Jun 2, 2017

Conversation

alfssobsd
Copy link
Contributor

If you use the flag "-internal" is substituted not a valid port to $SERVICE_CHECK_SCRIPT.
Please view and accept the changes, they solve this problem.

SERVICE_CHECK_SCRIPT=nc $SERVICE_IP $SERVICE_PORT | grep OK

fix service ip and port in consul interpolateService
@josegonzalez
Copy link
Member

@MattAitchison seems reasonable, can I merge?

@arentrue
Copy link

Hi,

So why is it still not merged?

@alfssobsd
Copy link
Contributor Author

alfssobsd commented Jun 2, 2017

Anyone alive? @MattAitchison

@mattatcha mattatcha merged commit 10cf074 into gliderlabs:master Jun 2, 2017
roman-vynar pushed a commit to Quiq/registrator that referenced this pull request Jul 10, 2017
fix service ip and port in consul interpolateService
@lnshi
Copy link

lnshi commented Jul 12, 2017

Sorry, my carelessness.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants