Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Windows detection #571

Merged
merged 1 commit into from
Jun 16, 2018

Conversation

kichristensen
Copy link
Contributor

Detect if running on Windows, if so default to the docker namedpipe

@josegonzalez
Copy link
Member

Registrator is meant to run within a container, in which case it's host operating system is always going to be linux based. Is that incorrect?

@jnovack
Copy link

jnovack commented Jun 27, 2017

https://docs.docker.com/docker-for-windows/faqs/#how-do-i-connect-to-the-remote-docker-engine-api

On Docker for Windows, clients can connect to the Docker Engine through a named pipe: npipe:////./pipe/docker_engine, or TCP socket at this URL: tcp://localhost:2375.

This sets DOCKER_HOST and DOCKER_CERT_PATH environment variables to the given values (for the named pipe or TCP socket, whichever you use).

@Nuschler
Copy link

host operating system can now be Windows Server or Linux
https://www.docker.com/docker-windows-server

@josegonzalez josegonzalez merged commit 827e0d8 into gliderlabs:master Jun 16, 2018
@josegonzalez
Copy link
Member

Thanks for the pull request!

This was referenced Jun 25, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants