Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screen sessions vertically split display incorrectly #129

Open
200sc opened this issue Nov 1, 2019 · 2 comments
Open

Screen sessions vertically split display incorrectly #129

200sc opened this issue Nov 1, 2019 · 2 comments

Comments

@200sc
Copy link

200sc commented Nov 1, 2019

On account of the newline to \r\n replace that happens here(https://github.com/gliderlabs/ssh/blob/master/session.go#L122), when running screen and splitting the screen vertically via CTRL+A + | (shift +\), the middle bar down the screen breaks off and ends up on the left side of the screen.

Screenshot:

image

Expected (this shows with the replacement commented out):

image

@belak
Copy link
Collaborator

belak commented Nov 7, 2019

This is a fun issue. I seem to remember this being added in as a hack to make it easier to add pty support, but I'm not completely sure.

infinisil added a commit to tweag/gliderlabs-ssh that referenced this issue Aug 10, 2021
As suggested by gliderlabs#129 to fix
side-by-side splits in screen/tmux
infinisil added a commit to tweag/gliderlabs-ssh that referenced this issue Aug 10, 2021
As suggested by gliderlabs#129 to fix
side-by-side splits in screen/tmux
@infinisil
Copy link

I just ran into this. I can confirm that removing those Replace fixed any issues with screen (or tmux in my case) and vertical splits. I did so in a fork here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants