Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Server.KeyboardInteractiveHandler #92

Merged
merged 2 commits into from
Jan 7, 2019

Conversation

aidansteele
Copy link
Contributor

I needed this in order to implement functionality similar to https://github.com/FiloSottile/whosthere#how-it-works (i.e. I wanted to print a custom error message for users who failed to present any acceptable public keys), so I added this handler.

I'm submitting it for your consideration because having it upstream means less work for me, but understand that it's pretty niche and might not be in the spirit of this project. Feel free to use or not :)

Copy link
Collaborator

@belak belak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable to me. It is a little bit of a niche, but it's fairly simple to add and exposes a feature of the official package without complicating anything.

ssh.go Outdated Show resolved Hide resolved
@belak
Copy link
Collaborator

belak commented Jan 7, 2019

I'm fine with merging this in for now, but note that it may be changed at a later date since we're looking at revamping how config works. Thanks for your contribution!

@belak belak merged commit bed87f3 into gliderlabs:master Jan 7, 2019
@aidansteele
Copy link
Contributor Author

That’s fair enough, and thank you! 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants