Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Project audit actions (WIP) #221

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

philipjackson
Copy link
Contributor

@philipjackson philipjackson commented Jul 29, 2022

Description

Accepts ProjectAuditActions from DOMINATE and displays them in the ProjectAuditTable. Depends on gliff-ai/dominate#783

TODO: details accordions for non-annotation actions, also the ProjectAuditAction interface really should be exported from a centralised interfaces repo (along with most other interfaces) instead of hackishly duplicated here.

We'll also need to make AUDIT accept team level audits and display those correctly.

Checklist:

Put an x in the boxes that apply to this pull request (you can also fill these out after opening the pull request). If you're unsure about any of these, don't hesitate to leave a comment on this pull request!

  • I have read the gliff.ai Contribution Guide.
  • I have requested to pull a branch and not from main.
  • I have checked all commit message styles match the requested structure.
  • My code follows the style guidelines of this project.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have performed a self-review of my own code.
  • I have assigned 3 or less reviewers.
  • New and existing unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • My changes generate no new warnings.
  • I have made corresponding changes to the documentation.
  • New database changes have been committed.
  • If appropriate, I have bumped any version numbers.

@gliff-ai-robot gliff-ai-robot added the feature [Improvement] New feature request. label Jul 29, 2022
@philipjackson philipjackson changed the title feat: Project audit actions feat: Project audit actions (WIP) Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature [Improvement] New feature request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants