feat: Make group-by functionality in SortPopover optional

gliff-ai · Jul 11, 2022 · dfbc34f · dfbc34f
1 parent 9a4c0a8
commit dfbc34f
Showing 1 changed file with 24 additions and 14 deletions.
diff --git a/src/sort/SortPopover.tsx b/src/sort/SortPopover.tsx
@@ -22,13 +22,15 @@ interface Props {
   filters: Filters;
   updateData: (func: (data: FilterData) => FilterData) => void;
   getLabelsFromKeys: (acc: DataKeyLabel[], key: string) => DataKeyLabel[];
+  showGroupBy?: boolean;
 }
 
 export const SortPopover = ({
   data,
   filters,
   updateData,
   getLabelsFromKeys,
+  showGroupBy,
 }: Props): ReactElement => {
   const [inputKey, setInputKey] = useState<DataKeyLabel>({
     key: "",
@@ -131,19 +133,21 @@ export const SortPopover = ({
                   />
                 </RadioGroup>
               </FormControl>
-              <FormControlLabel
-                control={
-                  <Checkbox
-                    checked={isGrouped}
-                    onChange={() => {
-                      filters.toggleIsGrouped();
-                      setIsGrouped((value) => !value);
-                    }}
-                    name="group-by"
-                  />
-                }
-                label="Group by value"
-              />
+              {showGroupBy && (
+                <FormControlLabel
+                  control={
+                    <Checkbox
+                      checked={isGrouped}
+                      onChange={() => {
+                        filters.toggleIsGrouped();
+                        setIsGrouped((value) => !value);
+                      }}
+                      name="group-by"
+                    />
+                  }
+                  label="Group by value"
+                />
+              )}
             </>
           )}
         </Paper>
@@ -160,7 +164,9 @@ export const SortPopover = ({
                 sortOrder === "asc"
               );
 
-              newMetadata = filters.groupByValue(newMetadata || metadata);
+              if (showGroupBy) {
+                newMetadata = filters.groupByValue(newMetadata || metadata);
+              }
 
               return newMetadata;
             });
@@ -171,3 +177,7 @@ export const SortPopover = ({
     </Popover>
   );
 };
+
+SortPopover.defaultProps = {
+  showGroupBy: true,
+};