Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Access for owners and collaborators #275

Merged
merged 17 commits into from
Nov 24, 2021
Merged

test: Access for owners and collaborators #275

merged 17 commits into from
Nov 24, 2021

Conversation

SilviaZeta
Copy link
Contributor

Description

adds tests on access for owners and collaborators and fixes a couple of things (see commits).

addresses gliff-ai/dominate/issues/384

Dependency changes

no

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • New migrations have been committed
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • If appropriate, I have bumped any version numbers

@github-actions

This comment has been minimized.

@SilviaZeta SilviaZeta marked this pull request as draft November 19, 2021 11:18
@github-actions

This comment has been minimized.

@ChasNelson1990
Copy link
Member

Well it seems to have skipped the Percy action....... could be that I broke it.... could be that it's ignoring it because it's a draft like I intended... @SilviaZeta when will you be ready to make Ready for Review?

@github-actions

This comment has been minimized.

@SilviaZeta SilviaZeta closed this Nov 19, 2021
@SilviaZeta SilviaZeta reopened this Nov 19, 2021
@github-actions

This comment has been minimized.

@SilviaZeta SilviaZeta marked this pull request as ready for review November 19, 2021 12:36
@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-meadow-05ee3f103-275.westeurope.azurestaticapps.net

@SilviaZeta SilviaZeta requested review from a team and removed request for cooper667, ChasNelson1990, philipjackson, ChrisBaidoo, Kinukeo and a team November 19, 2021 14:07
@ChasNelson1990 ChasNelson1990 requested review from a team, philipjackson and ChrisBaidoo and removed request for a team November 19, 2021 15:31
@ChrisBaidoo
Copy link
Contributor

ChrisBaidoo commented Nov 22, 2021

Screenshot 2021-11-22 at 15 20 24

We've somehow lost the blue background on hover.

philipjackson
philipjackson previously approved these changes Nov 23, 2021
@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-meadow-05ee3f103-275.westeurope.azurestaticapps.net

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-meadow-05ee3f103-275.westeurope.azurestaticapps.net

@cooper667 cooper667 self-requested a review November 24, 2021 10:47
@mergify mergify bot merged commit 61565e3 into main Nov 24, 2021
@mergify mergify bot deleted the issue384 branch November 24, 2021 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants