Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Access for owners and collaborators #206

Merged
merged 9 commits into from
Nov 18, 2021
Merged

test: Access for owners and collaborators #206

merged 9 commits into from
Nov 18, 2021

Conversation

SilviaZeta
Copy link
Contributor

Description

  • adds tests on access for owners and collaborators
  • switch to @gliff-ai/style icons

note: the act function from React Testing Library is used to address the warning " Warning: An update to ProjectsView inside a test was not wrapped in act(...).", which indicates that some changes happen only after the test has finished (e.g., some state being set). The warning was there for all views.

addresses gliff-ai/dominate/issues/384

Dependency changes

adds dependencies needed for React Testing Library to work with Jest (see package.json).

Testing

:-)

Documentation

no

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • New migrations have been committed
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • If appropriate, I have bumped any version numbers

@mergify mergify bot merged commit b33eae5 into main Nov 18, 2021
@mergify mergify bot deleted the issue384 branch November 18, 2021 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants