Fixed conversations issue

[mdshamoon]

Summary

The root cause for the issue:

onCompleted is getting called on every render which appends the same contacts at the end of the list after we click on loadmore. If contacts with same id's are appended to the list the apollo cache invalidates and restores the original data hence causing this issue.

Things I tried:

Using useLazyQuery's promise approach but it was not working and there are a few issues with that in apollo client. I have used the alternative that was suggested in the comments on the apollo client issues i.e. to use the client object directly.
With this it seems to be working fine.

[codecov]

Codecov Report

Patch coverage: 54.54% and project coverage change: -0.03 ⚠️

Comparison is base (0bf520f) 71.12% compared to head (d3dcec7) 71.10%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2322      +/-   ##
==========================================
- Coverage   71.12%   71.10%   -0.03%     
==========================================
  Files         229      229              
  Lines        8052     8049       -3     
  Branches     1731     1730       -1     
==========================================
- Hits         5727     5723       -4     
- Misses       1765     1766       +1     
  Partials      560      560              

Impacted Files	Coverage Δ
...onversations/ConversationList/ConversationList.tsx	65.96% <54.54%> (-1.05%)	⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[github-actions]

🚀 Deployed on https://deploy-preview-2322--fervent-hypatia-766178.netlify.app

[cypress]

Passing run #3256 ↗︎

0

176

0

0

0

Details:

Merge d3dcec7 into 0bf520f...
Project: Glific	Commit: 5bd2b91af7 ℹ️
Status: Passed	Duration: 38:17 💡
Started: Mar 24, 2023 7:36 AM	Ended: Mar 24, 2023 8:15 AM

_{This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.}

[kurund]

@mdshamoon

The issue still persists. Here are the steps to replicate.

1. Go to chat and click on the second contact.
2. Click contact load more
3. Click on any of newly added contact's in the list.
4. Contact clicked and additional 1 contact after above contact is duplicated.

[mdshamoon]

@kurund there are two issues that are causing this:

1. onCompleted is called on every click after we have clicked on Loadmore that adds duplicate contacts.
2. The search query is also returning some duplicate contacts with a different offset (This seems to happen only on local and not on production)

I have fixed the first case in this branch and created issue for the second in the backend glific/glific#2696.
Let me know if we can merge this and tackle that separately

[kurund]

looks good