Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added error message if error occurs while uploading #2348

Merged
merged 4 commits into from
Feb 28, 2023

Conversation

mdshamoon
Copy link
Member

Summary

Added error message if error occurs while uploading

@mdshamoon mdshamoon self-assigned this Feb 27, 2023
@github-actions
Copy link

github-actions bot commented Feb 27, 2023

@github-actions github-actions bot temporarily deployed to pull request February 27, 2023 09:03 Inactive
@codecov
Copy link

codecov bot commented Feb 27, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.23 🎉

Comparison is base (f1c7a1b) 72.92% compared to head (f827076) 73.16%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2348      +/-   ##
==========================================
+ Coverage   72.92%   73.16%   +0.23%     
==========================================
  Files         213      213              
  Lines        7318     7320       +2     
  Branches     1606     1606              
==========================================
+ Hits         5337     5356      +19     
+ Misses       1470     1449      -21     
- Partials      511      515       +4     
Impacted Files Coverage Δ
.../Chat/ChatMessages/AddAttachment/AddAttachment.tsx 67.44% <0.00%> (-1.61%) ⬇️
...ntainers/InteractiveMessage/InteractiveMessage.tsx 69.46% <0.00%> (+4.69%) ⬆️
src/containers/Auth/Login/Login.tsx 62.50% <0.00%> (+10.41%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cypress
Copy link

cypress bot commented Feb 27, 2023

2 failed and 1 flaky tests on run #3195 ↗︎

2 166 0 0 Flakiness 1

Details:

Merge 50f7b0c into e1a6baa...
Project: Glific Commit: 68302e0c8f ℹ️
Status: Failed Duration: 21:09 💡
Started: Feb 28, 2023 8:33 AM Ended: Feb 28, 2023 8:54 AM
Failed  setting/OrganizationSetting.spec.ts • 1 failed test

View Output Video

Test
Triggers (daily) > should create new trigger Screenshot
Failed  trigger/Trigger.spec.ts • 1 failed test

View Output Video

Test
Triggers (daily) > should create new trigger Screenshot
Flakiness  cypress/e2e/template/HSMTemplate.spec.ts • 1 flaky test

View Output Video

Test
HSM Template > should show not show sticker option Screenshot

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@github-actions github-actions bot temporarily deployed to pull request February 28, 2023 06:00 Inactive
@mdshamoon mdshamoon requested a review from kurund February 28, 2023 08:21
@github-actions github-actions bot temporarily deployed to pull request February 28, 2023 08:27 Inactive
Copy link
Contributor

@kurund kurund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@github-actions github-actions bot temporarily deployed to pull request February 28, 2023 21:10 Inactive
@kurund kurund merged commit 6fbe0cf into master Feb 28, 2023
@kurund kurund deleted the enhancement/error-messahe branch February 28, 2023 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants