Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collection contact filter based on name or phone #2375

Merged
merged 1 commit into from
Apr 3, 2023
Merged

Conversation

pankaj-ag
Copy link
Collaborator

@pankaj-ag pankaj-ag commented Apr 2, 2023

Target issue: #2376

  1. Changed the filter parameter to term from name in the contact collection list screen's search. It filters the contacts based on name or phone.

@github-actions
Copy link

github-actions bot commented Apr 2, 2023

@github-actions github-actions bot temporarily deployed to pull request April 2, 2023 15:05 Inactive
@codecov
Copy link

codecov bot commented Apr 2, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.07 ⚠️

Comparison is base (b94e122) 71.12% compared to head (95e1419) 71.06%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2375      +/-   ##
==========================================
- Coverage   71.12%   71.06%   -0.07%     
==========================================
  Files         229      229              
  Lines        8049     8049              
  Branches     1730     1730              
==========================================
- Hits         5725     5720       -5     
- Misses       1763     1770       +7     
+ Partials      561      559       -2     
Impacted Files Coverage Δ
...ct/CollectionContactList/CollectionContactList.tsx 100.00% <ø> (ø)

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cypress
Copy link

cypress bot commented Apr 2, 2023

2 failed tests on run #3272 ↗︎

2 174 0 0 Flakiness 0

Details:

Merge 95e1419 into b94e122...
Project: Glific Commit: 9b558d31c3 ℹ️
Status: Failed Duration: 29:05 💡
Started: Apr 2, 2023 3:14 PM Ended: Apr 2, 2023 3:43 PM
Failed  roles/staff/collection/Collection.spec.ts • 1 failed test

View Output Video

Test Artifacts
Role - Staff - Collection > should remove member from collection Output Screenshots
Failed  template/HSMTemplate.spec.ts • 1 failed test

View Output Video

Test Artifacts
HSM Template > should create new HSM template Output Screenshots

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@mdshamoon mdshamoon self-requested a review April 3, 2023 04:17
Copy link
Member

@mdshamoon mdshamoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mdshamoon mdshamoon merged commit 2dd23fa into master Apr 3, 2023
@mdshamoon mdshamoon deleted the feature/2496 branch April 3, 2023 04:18
@mdshamoon mdshamoon linked an issue Apr 3, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search contacts with in collection.
2 participants