Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Readme file bug improvement #2404

Merged
merged 4 commits into from
May 30, 2023
Merged

Readme file bug improvement #2404

merged 4 commits into from
May 30, 2023

Conversation

aashi-ihsaa
Copy link
Contributor

.env file readme improvement

mdshamoon
mdshamoon approved these changes May 30, 2023
View reviewed changes
Copy link
Member

@mdshamoon mdshamoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested the docker stuff. Hopefully its working fine. I think we should take up dockerizing the frontend and the backend.

@mdshamoon
Copy link
Member

@aashi-ihsaa please resolve conflicts. Will merge after that

@aashi-ihsaa
Copy link
Contributor Author

Resolved the conflict

@mdshamoon mdshamoon merged commit 00b9e80 into glific:master May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdshamoon mdshamoon mdshamoon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aashi-ihsaa @mdshamoon