Update loading screen #2433
Merged
Update loading screen #2433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2433 +/- ##
=======================================
Coverage 73.55% 73.56%
=======================================
Files 236 237 +1
Lines 8245 8249 +4
Branches 1753 1755 +2
=======================================
+ Hits 6065 6068 +3
Misses 1594 1594
- Partials 586 587 +1
☔ View full report in Codecov by Sentry. |
mdshamoon
requested changes
Jul 5, 2023
| @@ -448,7 +448,7 @@ export const FlowEditor = () => { | |||
| <ResetFlowIcon /> Reset flow counts | |||
| </Button> | |||
| <div id="flow" /> | |||
| {loading && <Loading />} | |||
| {loading && <Loading showTip={true}/>} | |||
There was a problem hiding this comment.
Suggested change
| {loading && <Loading showTip={true}/>} | |
| {loading && <Loading showTip />} |
productTips.ts
Outdated
| const productTips: FlowTip[] = [ | ||
| 'Always ensure you have "Published" the flow before testing it.', | ||
| 'Do not forget to add labels in the flow wherever you want the data to get captured.', | ||
| 'Wherever you want the data to get captured.', |
There was a problem hiding this comment.
Suggested change
| 'Wherever you want the data to get captured.', | |
| 'Wherever you want the data to get captured.', |
Remove this
productTips.ts
Outdated
Comment on lines
8
to
9
| 'Flows can become harder to maintain (modify)', | ||
| 'Debug when they become very large.', |
There was a problem hiding this comment.
Suggested change
| 'Flows can become harder to maintain (modify)', | |
| 'Debug when they become very large.', | |
| 'Flows can become harder to maintain (modify), debug when they become very large.', |
productTips.ts
Outdated
Comment on lines
12
to
13
| 'When getting user response from buttons and lists', | ||
| 'Prepare for additional cases', |
There was a problem hiding this comment.
Suggested change
| 'When getting user response from buttons and lists', | |
| 'Prepare for additional cases', | |
| 'When getting user response from buttons and lists, prepare for additional cases', |
productTips.ts
Outdated
| "Make use of flows like 'Enter another flow' to keep the flows shorter for bringing in modularity", | ||
| 'Easier maintenance, readability & troubleshooting, reusability, and better performance', | ||
| 'While naming the variables, make sure that the name is related to the value it is going to hold.', | ||
| "Also, don't use personal names, generic names like test while naming variables.", |
There was a problem hiding this comment.
Suggested change
| "Also, don't use personal names, generic names like test while naming variables.", | |
| "Don't use personal names, generic names like test while naming variables.", |
productTips.ts
Outdated
| 'If applying for an image template, make sure the attached media file has a message in the same language.', | ||
| 'When using button template always avoid flow keywords as buttons', | ||
| "Make use of flows like 'Enter another flow' to keep the flows shorter for bringing in modularity", | ||
| 'Easier maintenance, readability & troubleshooting, reusability, and better performance', |
There was a problem hiding this comment.
Suggested change
| 'Easier maintenance, readability & troubleshooting, reusability, and better performance', | |
| 'Easier maintenance, readability & troubleshooting, reusability, and better performance', |
Remove this
mdshamoon
approved these changes
Jul 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have updated the loading screen and added a tip to the loading screen.