Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed search bar in collections list #3075

Merged
merged 4 commits into from
Sep 10, 2024
Merged

Fixed search bar in collections list #3075

merged 4 commits into from
Sep 10, 2024

Conversation

akanshaaa19
Copy link
Member

target issue is #3043

@akanshaaa19 akanshaaa19 self-assigned this Sep 6, 2024
@akanshaaa19 akanshaaa19 linked an issue Sep 6, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Sep 6, 2024

@github-actions github-actions bot temporarily deployed to pull request September 6, 2024 14:37 Inactive
@github-actions github-actions bot temporarily deployed to pull request September 6, 2024 15:00 Inactive
Copy link

codecov bot commented Sep 6, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.29%. Comparing base (da575d1) to head (5325db2).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
...onversations/ConversationList/ConversationList.tsx 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3075      +/-   ##
==========================================
+ Coverage   80.20%   80.29%   +0.08%     
==========================================
  Files         322      322              
  Lines       10382    10383       +1     
  Branches     2213     2213              
==========================================
+ Hits         8327     8337      +10     
+ Misses       1407     1393      -14     
- Partials      648      653       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@akanshaaa19 akanshaaa19 requested a review from kurund September 6, 2024 15:05
@github-actions github-actions bot temporarily deployed to pull request September 6, 2024 15:07 Inactive
Copy link

cypress bot commented Sep 6, 2024

Glific    Run #5211

Run Properties:  status check failed Failed #5211  •  git commit 3f4435a991 ℹ️: Merge 5325db2bcc92c411b8312b5afafdf6851cc00de3 into da575d1652b6a0a3501235264184...
Project Glific
Branch Review fix/collections-search
Run status status check failed Failed #5211
Run duration 30m 02s
Commit git commit 3f4435a991 ℹ️: Merge 5325db2bcc92c411b8312b5afafdf6851cc00de3 into da575d1652b6a0a3501235264184...
Committer Akansha Sakhre
View all properties for this run ↗︎

Test results
Tests that failed  Failures 2
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 167
View all changes introduced in this branch ↗︎

Tests for review

Failed  contactImport/ContactImport.spec.ts • 1 failed test

View Output

Test Artifacts
Importing contacts > should upload contacts Test Replay Screenshots
Failed  notification/notification.spec.ts • 1 failed test

View Output

Test Artifacts
Notification list > downloads csv report for contact import Test Replay Screenshots

@github-actions github-actions bot temporarily deployed to pull request September 9, 2024 07:36 Inactive
Copy link
Contributor

@kurund kurund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@kurund kurund merged commit 3588b85 into master Sep 10, 2024
9 of 13 checks passed
@kurund kurund deleted the fix/collections-search branch September 10, 2024 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to search Colections on the Chat screen
2 participants