Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved sync button to top #3147

Merged
merged 3 commits into from
Dec 10, 2024
Merged

Moved sync button to top #3147

merged 3 commits into from
Dec 10, 2024

Conversation

akanshaaa19
Copy link
Member

No description provided.

@akanshaaa19 akanshaaa19 requested a review from kurund November 27, 2024 18:40
@akanshaaa19 akanshaaa19 self-assigned this Nov 27, 2024
Copy link

github-actions bot commented Nov 27, 2024

@github-actions github-actions bot temporarily deployed to pull request November 27, 2024 18:42 Inactive
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 81.72%. Comparing base (f5c05d2) to head (272f2ce).
Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
src/containers/Template/List/Template.tsx 66.66% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3147      +/-   ##
==========================================
+ Coverage   81.70%   81.72%   +0.02%     
==========================================
  Files         329      329              
  Lines       10563    10563              
  Branches     2235     2235              
==========================================
+ Hits         8630     8633       +3     
+ Misses       1318     1316       -2     
+ Partials      615      614       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cypress bot commented Nov 27, 2024

Glific    Run #5440

Run Properties:  status check passed Passed #5440  •  git commit 91358f0572 ℹ️: Merge eabe8f02ac0f5c8713be3e9737b41df2fab25b7a into 945f5a20487da5394dcd36c3a161...
Project Glific
Branch Review sync-hsm
Run status status check passed Passed #5440
Run duration 24m 57s
Commit git commit 91358f0572 ℹ️: Merge eabe8f02ac0f5c8713be3e9737b41df2fab25b7a into 945f5a20487da5394dcd36c3a161...
Committer Akansha Sakhre
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 169
View all changes introduced in this branch ↗︎

Copy link
Contributor

@kurund kurund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please resolve the merge conflicts.

@github-actions github-actions bot temporarily deployed to pull request December 8, 2024 15:29 Inactive
@akanshaaa19 akanshaaa19 requested a review from kurund December 9, 2024 04:53
Copy link
Contributor

@kurund kurund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

@github-actions github-actions bot temporarily deployed to pull request December 10, 2024 22:29 Inactive
@kurund kurund merged commit 8995031 into master Dec 10, 2024
10 of 11 checks passed
@kurund kurund deleted the sync-hsm branch December 10, 2024 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants