Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HSM: Fixed Language dropdown #3188 #3189

Merged
merged 4 commits into from
Jan 15, 2025
Merged

HSM: Fixed Language dropdown #3188 #3189

merged 4 commits into from
Jan 15, 2025

Conversation

akanshaaa19
Copy link
Member

When creating a hsm template language dropdown is not working as expected.

Steps to reproduce:

  1. Go to create hsm page
  2. Select language from dropdown
  3. Type in any other field
  4. The language selected changes into the previous one

Copy link

github-actions bot commented Jan 15, 2025

@github-actions github-actions bot temporarily deployed to pull request January 15, 2025 17:25 Inactive
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 81.85%. Comparing base (4976ab5) to head (e1170f8).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
src/containers/HSM/HSM.tsx 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3189      +/-   ##
==========================================
+ Coverage   81.82%   81.85%   +0.03%     
==========================================
  Files         327      327              
  Lines       10539    10540       +1     
  Branches     2177     2177              
==========================================
+ Hits         8624     8628       +4     
+ Misses       1303     1300       -3     
  Partials      612      612              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@akanshaaa19 akanshaaa19 requested a review from kurund January 15, 2025 17:29
@github-actions github-actions bot temporarily deployed to pull request January 15, 2025 17:34 Inactive
@github-actions github-actions bot temporarily deployed to pull request January 15, 2025 17:54 Inactive
Copy link

cypress bot commented Jan 15, 2025

Glific    Run #5517

Run Properties:  status check passed Passed #5517  •  git commit 8f725ada78 ℹ️: Merge 4d4590bdc44e2c51d27b8b2755544283ab11d45d into 4976ab5e6f737f94ddf0d7d4f93f...
Project Glific
Branch Review fix/hsm-language
Run status status check passed Passed #5517
Run duration 26m 17s
Commit git commit 8f725ada78 ℹ️: Merge 4d4590bdc44e2c51d27b8b2755544283ab11d45d into 4976ab5e6f737f94ddf0d7d4f93f...
Committer Akansha Sakhre
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 172
View all changes introduced in this branch ↗︎

@github-actions github-actions bot temporarily deployed to pull request January 15, 2025 23:49 Inactive
Copy link
Contributor

@kurund kurund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have made minor code changes to improve readability

@kurund kurund merged commit 19feedc into master Jan 15, 2025
9 checks passed
@kurund kurund deleted the fix/hsm-language branch January 15, 2025 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants