Merge pull request #1354 from glimmerjs/loose-lexical-part2

Followup for loose-mode lexical scope
glimmerjs · Oct 22, 2021 · bdabdc4 · bdabdc4
2 parents b1a69ad + 978c924
commit bdabdc4
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/packages/@glimmer/compiler/lib/compiler.ts b/packages/@glimmer/compiler/lib/compiler.ts
@@ -124,19 +124,17 @@ export function precompile(
     isStrictMode: options.strictMode ?? false,
   };
 
-  if (!options.strictMode) {
+  if (usedLocals.length === 0) {
     delete templateJSONObject.scope;
   }
 
   // JSON is javascript
   let stringified = JSON.stringify(templateJSONObject);
 
-  if (options.strictMode && usedLocals.length > 0) {
+  if (usedLocals.length > 0) {
     let scopeFn = `()=>[${usedLocals.join(',')}]`;
 
     stringified = stringified.replace(`"${SCOPE_PLACEHOLDER}"`, scopeFn);
-  } else {
-    stringified = stringified.replace(`"${SCOPE_PLACEHOLDER}"`, 'null');
   }
 
   return stringified;