Fix source checking when parsing {{~!~}} and the like. #1430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 26, 2023
Closed
|
I've been helping a client with some upgrades recently and found this message went away once the app was upgraded to 5.12. Probably can close now? |
|
I am on 5.12 and I still very much have these messages. |
|
@NullVoxPopuli, @wycats - could you please take a look at this PR if it really fixes the issue at hand? And also the other one? This has been an issue for quite a while now... |
chancancode
added a commit
that referenced
this pull request
Feb 21, 2025
Re-apply #1430 with a more robust implementation and tests Also turns the warning into a `localAssert()` so it gets stripped before reaching downstream consumers. This relates to #1431 in that this removes the warning, so to the extent that #1431 was motivated by sliencing the warning in Ember builds, it avoids the issue. But I haven't investigated the root cause of that issue and whether it is indicative of an actual bug somewhere deeper. Fixes emberjs/ember.js#19392 Co-authored-by: Lee Nave <lee.nave@ovation.io>
chancancode
added a commit
that referenced
this pull request
Feb 21, 2025
Re-apply #1430 with a more robust implementation and tests Also turns the warning into a `localAssert()` so it gets stripped before reaching downstream consumers. This relates to #1431 in that this removes the warning, so to the extent that #1431 was motivated by sliencing the warning in Ember builds, it avoids the issue. But I haven't investigated the root cause of that issue and whether it is indicative of an actual bug somewhere deeper. Fixes emberjs/ember.js#19392 Co-authored-by: Lee Nave <lee.nave@ovation.io>
|
Covered by #1717 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a warning that derives from several of these statements in
ember-prism, which are intended to strip whitespace without otherwise doing anything:Presently these result in a compiler warning when building
ember-prismor any addon which consumes it:Fixes one cause of emberjs/ember.js#19392
When fixing this I decided some tests would be nice to add even though they don't cover this fix. Not really thinking it is worth a test specifically targeting this case, though.