Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup the cache server #1482

Merged
merged 7 commits into from
Nov 2, 2023
Merged

Setup the cache server #1482

merged 7 commits into from
Nov 2, 2023

Conversation

NullVoxPopuli
Copy link
Contributor

@NullVoxPopuli NullVoxPopuli commented Nov 1, 2023

Because we now build each package 3 times (prod (ESM), dev (ESM), and (CJS)), and because building is required before linting, the lint job takes a while.

By using the cache server, we can hopefully speed up parts of CI.

For example, previously, in: #1481 -- https://github.com/glimmerjs/glimmer-vm/actions/runs/6721577834/usage

  • Total Runtime is 19m43s
  • Human perceived time is 9m 42s

With this PRs changes, we see: https://github.com/glimmerjs/glimmer-vm/actions/runs/6726246999/usage

  • Total runtime is about the same
  • human percieved time on no-cache hits is slower, but as I was iterating on this, we have the potential to be 2x as fast, I think.

@NullVoxPopuli NullVoxPopuli force-pushed the use-cache-server branch 3 times, most recently from 6bbedae to aefe74a Compare November 1, 2023 20:56
@NullVoxPopuli
Copy link
Contributor Author

it's not yet perfect, but its an improvement.

@NullVoxPopuli NullVoxPopuli merged commit 77faa4d into master Nov 2, 2023
@NullVoxPopuli NullVoxPopuli deleted the use-cache-server branch November 2, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant