Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[perf] avoid double memory usage in append opcodes #1518

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

lifeart
Copy link
Contributor

@lifeart lifeart commented Dec 5, 2023

No description provided.

@lifeart lifeart force-pushed the perf-remove-fill-nulls branch from 9ae91d8 to 80c234e Compare December 5, 2023 22:00
@NullVoxPopuli
Copy link
Contributor

NullVoxPopuli commented Dec 5, 2023

This one def wants to wait on #1501
(I think)

@NullVoxPopuli
Copy link
Contributor

@lifeart did you have numbers on this one? I think something this focused is fine to land before error recovery, as the rebase situation wouldn't be too bad over there

@lifeart
Copy link
Contributor Author

lifeart commented Dec 20, 2023

@NullVoxPopuli no numbers here, I think we could count it as cleanup from IE11 support, because Array.fill not working in 11 - https://caniuse.com/mdn-javascript_builtins_array_fill
And list of functions is created to simulate this.

Most of usages is static things (initialized once), we unable to catch 'difference'.

Only improvement kinda here
image
(looks like it's a mistake in code and .slice(); is some left copy-pasta from somewhere.

@NullVoxPopuli NullVoxPopuli merged commit 8e24991 into glimmerjs:main Dec 20, 2023
5 checks passed
@lifeart lifeart deleted the perf-remove-fill-nulls branch December 20, 2023 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants